feat: add support for typescript AST to getStaticValue, and ReferenceTracker
#255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
May 1, 2025
package.json
Outdated
| @@ -46,6 +46,7 @@ | |||
| "lint:knip": "knip", | |||
| "lint": "run-p lint:*", | |||
| "test": "c8 mocha --reporter dot \"test/*.mjs\"", | |||
| "debug": "mocha --reporter dot \"test/*.mjs\"", | |||
There was a problem hiding this comment.
How about test and test-coverage instead.
There was a problem hiding this comment.
Great idea! I changed the script names.
fisker
approved these changes
May 1, 2025
aladdin-add
approved these changes
May 2, 2025
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #250
This PR adds support for typescript AST to
getStaticValue(), andReferenceTrackerclass.Note that TypeScript type definitions still do not accept TSESTree node types.
If I change the type to accept TSESTree, it no longer accepts ESLint's node types. I'm still not sure what to do about this.