Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Typescript 5.5 generated types dont include typedef #320

Closed
scagood opened this issue Jul 26, 2024 · 0 comments · Fixed by #367
Closed

🩹 Typescript 5.5 generated types dont include typedef #320

scagood opened this issue Jul 26, 2024 · 0 comments · Fixed by #367
Labels
bug typescript

Comments

@scagood
Copy link

scagood commented Jul 26, 2024

See also: #316 #317 #212

In v17.10.0 we updated to ts@5.5, which caused the Configs type to not get generated in the output.

Typescript 5.5 generated types:

image

Typescript 5.4 generated types:

image

This is bad because we did not notice in the tests that the Configs were missing!

We should implement tests to check the output types to ensure they're at least valid. (eg #212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Improve typescript types and strictness scagood/eslint-plugin-n
1 participant
@scagood