Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Add meta.hasSuggestions property to meta-property-ordering rule #119

Conversation

bmish
Copy link
Member

@bmish bmish commented Jun 12, 2021

It makes most sense to order the new ESLint 8 property meta.hasSuggestions (whether a rule provides suggestions) after the related property meta.fixable (whether a rule is autofixable).

https://eslint.org/blog/2021/06/whats-coming-in-eslint-8.0.0#rules-with-suggestions-now-require-the-metahassuggestions-property

Copy link
Contributor

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add changed the title Add meta.hasSuggestions property to meta-property-ordering rule Breaking: Add meta.hasSuggestions property to meta-property-ordering rule Jun 13, 2021
@aladdin-add
Copy link
Contributor

it seems a breaking change to change the default options. :)

@aladdin-add
Copy link
Contributor

we need to resolve the conflicts. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants