Skip to content

Commit

Permalink
Upgrade: eslint and other deps (#92)
Browse files Browse the repository at this point in the history
* Upgrade: eslint v6

* Upgrade: eslint v7

* Fix: no-deprecated-report-api error

* Fix: require-meta-fixable reported error
  • Loading branch information
aladdin-add authored Apr 8, 2020
1 parent 66aeb87 commit 93d082c
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 8 deletions.
5 changes: 5 additions & 0 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ extends:
- plugin:self/all
root: true
rules:
comma-dangle:
- error
- arrays: always-multiline
objects: always-multiline
functions: never # disallow trailing commas in function(es2017)
require-jsdoc: error
self/meta-property-ordering: off
self/require-meta-docs-url: off
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@
"chai": "^4.1.0",
"dirty-chai": "^2.0.1",
"escope": "^3.6.0",
"eslint": "^5.9.0",
"eslint": "^7.0.0-alpha.3",
"eslint-config-not-an-aardvark": "^2.1.0",
"eslint-plugin-node": "^8.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-self": "^1.0.1",
"espree": "^4.1.0",
"estraverse": "^4.2.0",
"espree": "^6.2.1",
"estraverse": "^5.0.0",
"lodash": "^4.17.2",
"mocha": "^5.2.0"
"mocha": "^7.1.1"
},
"peerDependencies": {
"eslint": ">=5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tests/lib/rules/no-deprecated-report-api.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

const rule = require('../../../lib/rules/no-deprecated-report-api');
const RuleTester = require('eslint').RuleTester;
const ERROR = [{ message: 'Use the new-style context.report() API.', type: 'CallExpression' }];
const ERROR = { message: 'Use the new-style context.report() API.', type: 'Identifier' };

// ------------------------------------------------------------------------------
// Tests
Expand Down
4 changes: 2 additions & 2 deletions tests/lib/rules/require-meta-fixable.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
const rule = require('../../../lib/rules/require-meta-fixable');
const RuleTester = require('eslint').RuleTester;

const MISSING_ERROR = [{ message: 'Fixable rules must export a `meta.fixable` property.', type: 'FunctionExpression' }];
const INVALID_ERROR = [{ message: '`meta.fixable` must be either `code`, `whitespace` or `null`.', type: 'Property' }];
const MISSING_ERROR = { message: 'Fixable rules must export a `meta.fixable` property.', type: 'FunctionExpression' };
const INVALID_ERROR = { message: '`meta.fixable` must be either `code`, `whitespace` or `null`.', type: 'Property' };

// ------------------------------------------------------------------------------
// Tests
Expand Down

0 comments on commit 93d082c

Please sign in to comment.