-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: separate the rules of ES2022 - ES2024 by features #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
force-pushed
the
separate-features
branch
from
April 19, 2024 14:28
861e11e
to
0283cdd
Compare
ota-meshi
changed the title
feat!: separate rules by features
feat!: separate rules by features for ES2022 - ES2024
Apr 19, 2024
ota-meshi
changed the title
feat!: separate rules by features for ES2022 - ES2024
feat!: separate the rules of ES2022 - ES2024 by features
Apr 21, 2024
ota-meshi
force-pushed
the
separate-features
branch
2 times, most recently
from
June 1, 2024 06:11
25d9a21
to
5fc0d88
Compare
ota-meshi
force-pushed
the
separate-features
branch
from
June 26, 2024 23:58
5fc0d88
to
6315da8
Compare
ota-meshi
force-pushed
the
separate-features
branch
from
July 1, 2024 06:32
6315da8
to
5dfac29
Compare
aladdin-add
reviewed
Jul 1, 2024
docs/configs/index.md
Outdated
## no-array-grouping | ||
|
||
disallow proposal ES2024 [Array Grouping](https://github.com/tc39/proposal-array-grouping)\ | ||
⚠️ This config will be changed in the minor versions of this plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given es2024 has been released, This config will be changed
?
The original rules were not removed, is this change still a breaking change? |
Yeah, I think it's a breaking change because it changes the config. |
aladdin-add
approved these changes
Jul 1, 2024
ota-meshi
force-pushed
the
separate-features
branch
from
July 1, 2024 07:11
5dfac29
to
8eeee70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits some rules and adds new ones.
As a related task, add a new
no-intl-numberformat-v3
config.Close #149, and related to #134
The aim of splitting the rules is to allow you to create your own preferred configuration that is more in line with the compatibility of each JavaScript engine.
Each rule below modifies the rules and config that hang below it.