Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: separate the rules of ES2022 - ES2024 by features #150

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Apr 19, 2024

This PR splits some rules and adds new ones.
As a related task, add a new no-intl-numberformat-v3 config.

Close #149, and related to #134

The aim of splitting the rules is to allow you to create your own preferred configuration that is more in line with the compatibility of each JavaScript engine.

Each rule below modifies the rules and config that hang below it.

  • no-object-map-groupby rule
    • no-map-groupby rule
    • no-object-groupby rule
    • no-array-grouping config
  • no-string-prototype-iswellformed-towellformed rule
    • no-string-prototype-iswellformed rule
    • no-string-prototype-towellformed rule
    • no-is-usv-string config
  • no-array-string-prototype-at rule
    • no-array-prototype-at rule
    • no-string-prototype-at
    • no-relative-indexing-method config
  • no-class-fields rule rule
    • no-class-instance-fields rule
    • no-class-private-fields rule
    • no-class-private-methods rule
    • no-class-static-fields rule
    • no-class-fields config

@ota-meshi ota-meshi changed the title feat!: separate rules by features feat!: separate rules by features for ES2022 - ES2024 Apr 19, 2024
@ota-meshi ota-meshi changed the title feat!: separate rules by features for ES2022 - ES2024 feat!: separate the rules of ES2022 - ES2024 by features Apr 21, 2024
@ota-meshi ota-meshi force-pushed the separate-features branch 2 times, most recently from 25d9a21 to 5fc0d88 Compare June 1, 2024 06:11
@ota-meshi ota-meshi marked this pull request as ready for review June 26, 2024 23:58
@ota-meshi ota-meshi requested a review from a team June 27, 2024 00:00
@aladdin-add aladdin-add self-requested a review June 28, 2024 09:41
## no-array-grouping

disallow proposal ES2024 [Array Grouping](https://github.com/tc39/proposal-array-grouping)\
⚠️ This config will be changed in the minor versions of this plugin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given es2024 has been released, This config will be changed?

@aladdin-add
Copy link
Contributor

The original rules were not removed, is this change still a breaking change?

@ota-meshi
Copy link
Member Author

Yeah, I think it's a breaking change because it changes the config.

@aladdin-add aladdin-add merged commit 3a31ae4 into master Jul 1, 2024
13 checks passed
@aladdin-add aladdin-add deleted the separate-features branch July 1, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize rules for proposals vs rules for features
2 participants