Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include children_group_ids in /markets/groups/{market_group_id}/ #937

Open
4 of 8 tasks
Blacksmoke16 opened this issue May 26, 2018 · 2 comments
Open
4 of 8 tasks

Comments

@Blacksmoke16
Copy link
Member

Feature Request

Include an array of children_group_ids in the response of /markets/groups/{market_group_id}/

Use case

Would allow easy traversal of a high level market group to iteratively aggergate types belonging to that high level group.

Authentication

A public route, no auth required.

Example return

Propose what an example return might look like. E.g.:

{
    "description": "Capsuleers have several options for modifying their personal capabilities, including cybernetic implants and biochemical boosters",
    "market_group_id": 24,
    "name": "Implants & Boosters",
    "types": [],
    "children_group_ids": [23, 977]
}

Checklist

Check all boxes that apply to this issue:

  • Feature request description is provided
  • Use case exists
  • Feature requires a new route
  • Feature adds data to existing route
  • Feature requires new auth scope
  • Feature can reuse existing scope
  • Feature does not require auth
  • Meta feature, applies to all routes
@fuzzysteve
Copy link

The one thing I'd suggest adding is a top level group. for where there is no parent.

Just to start the tree.

@Blacksmoke16
Copy link
Member Author

I would be ok with that as well. The main reason behind this suggestion is that for a given group_id you have no way to know where in the tree you are, without searching all the other group_ids.

However having the children_ids would allow you to pick an arbitrary group and find the types below it, versus always having to start from the top most group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants