Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add all available fleets for a given character to the fleet endpoint #887

Open
CodeUrself opened this issue Apr 29, 2018 · 9 comments
Labels
esi-fleets feature request gd-approved Issue has been approved by Game Design.

Comments

@CodeUrself
Copy link

Feature request

Hi!

It came to my attention that the fleet endpoint doesnt list all available fleets for a given character (yet). It would be pretty cool if we could get that endpoint as well, since all other fleet-related endpoints are already implemented.

Route

/characters/{character_id}/fleet/ returns the information about the fleet the character is currently in.

/characters/{character_id}/fleet/all or similar could return all available fleets for the character.

Use case

Fleet participation and other fleet management related things can already be implemented with the existing endpoints, however, fleets are always differently named or run under a different person. Identifying the fleet that needs to be tracked/managed by listening all available fleets first would help this in an automated way.

I think great opportunities for websites that list public NPSI fleets could also emerge. People would be able to see if fleets are being run and who runs it, i'm thinking about Specture Fleet, Zarvox, BjornBee or BombersBar. One quick glance gives everyone the opportunity to find out where they can go to pew pew.
I think it would work great for looser assemblies of more casual groups, newer players or NPSI participants.

Coalition-wide metrics for fleets are currently also heavily favored towards big power blocs, since they have a heavily supporting IT-team that goes above & beyond implementing these metrics manually, by pasting and analyzing D-scans etc. For smaller groups it would be beneficial if that problem could be solved with just an additional ESI endpoint.

Example returns

fleet_id* | integer($int64) returns the fleet ID
fleet_name* | string - Returns the fleet name
fleet_boss | integer($int64) returns the character ID of fleet boss
fleet_location | integer($int64) returns the system ID of the system the fleet is currently in*

This would only apply if the fleet location is set to be displayed, otherwise this would return -1.

Previous XML or CREST route

N/A as far as I know

Thanks in advance!

@CodeUrself
Copy link
Author

I'd like to add that it seems the endpoint also already exists on CCP's side but hasnt been exposed to ESI (yet, hopefully).

https://i.imgur.com/GLIDost.png
https://i.imgur.com/5g1xG4T.png

@CodeUrself
Copy link
Author

Now, regarding the actual issue, you could probably skip including the fleet_id in the returns as there is no way for you to use that information in the first place without being in the fleet in some fashion.

Agreed. The fleet ID is unnecessary here unless there would be a method to join such fleet with an ESI POST endpoint.

Thanks for the feedback!

@a-tal a-tal added feature request esi-fleets gd-feedback-pending Issue requires Game Design feedback and has been submitted for review. labels May 2, 2018
@a-tal
Copy link
Contributor

a-tal commented May 2, 2018

sent for GD feedback

@NyxVxyN
Copy link

NyxVxyN commented May 5, 2018

All I can see is this being automated spying, yet adding to multiple of the nullsec entities bots capabilities...

@Aidansavage
Copy link

All I can see is this being automated spying, yet adding to multiple of the nullsec entities bots capabilities...

And how would you explain that? Even beyond the fact that if CCP has reason to believe there's any malicious activity happening with an app, they can disable it? You also say it like people dont already have spies in other entities that can get this information to begin with.

@a-tal a-tal added gd-approved Issue has been approved by Game Design. and removed gd-feedback-pending Issue requires Game Design feedback and has been submitted for review. labels May 7, 2018
@a-tal
Copy link
Contributor

a-tal commented May 7, 2018

approved by game design

@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi deleted a comment from CodeUrself May 7, 2018
@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi deleted a comment from Aidansavage May 7, 2018
@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi deleted a comment from NathenSample May 7, 2018
@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi deleted a comment from Aidansavage May 7, 2018
@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi deleted a comment from DaneelTrevize May 7, 2018
@esi esi locked as off-topic and limited conversation to collaborators May 7, 2018
@a-tal
Copy link
Contributor

a-tal commented May 7, 2018

the discussion here was all sorts of off-topic. let's try to stay focused on the issue at hand in the future.

apologies, you cannot leave a 👍 reaction on this issue anymore

@esi esi unlocked this conversation May 18, 2018
@jowrjowr
Copy link

open for business don't shit it up too hard

@Flupster
Copy link

Did this issue ever come to fruition? if not could we get a second look and potentially have this endpoint available, as it stands afaik you still have to guess the fleet boss which can be problematic and bounced failed requests until you figure out the boss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esi-fleets feature request gd-approved Issue has been approved by Game Design.
Projects
None yet
Development

No branches or pull requests

6 participants