Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase /characters/{character_id}/mail/ maxItems to something higher than 50 #867

Open
antihax opened this issue Apr 23, 2018 · 3 comments

Comments

@antihax
Copy link
Contributor

antihax commented Apr 23, 2018

Feature request

Could maxItems for /characters/{character_id}/mail/ be increased to 500 or 1000?

Use Case

Requesting the whole mailbox currently takes a very long time as you cannot predict last_mail_id without completing each request to pull concurrently.

On a mailbox of 2000, that is 40 consecutive calls at around 1 second each.

@a-tal
Copy link
Contributor

a-tal commented Apr 24, 2018

we'd like to change this to use the standard ESI pagination (including x-pages) rather than the last_mail_id concept.

@bsamuels453
Copy link

in its current state, I can pause an evemail scanning job and restart it later. this is important for this endpoint because of the vast number of evemails people accumulate over the years.

if this endpoint switches to x-pages, I will have to completely restart the job from page 1 every time the cached data is refreshed, or as snowedin pointed out, store the page number and dedupe any evemails that have been "pushed back" by new evemails

@antihax
Copy link
Contributor Author

antihax commented Apr 24, 2018

Can haz increase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants