Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/characters/{character_id}/fleet/ undocumented/malformed 403/409 response #848

Open
DaneelTrevize opened this issue Apr 17, 2018 · 2 comments

Comments

@DaneelTrevize
Copy link

Bug

Attempting to query 1 character's current fleet while providing the auth token of another results in a case-specific response body, but a reused response code (403 is documented as being for Forbidden, and returning a body containing an sso_status field, which this response did not).

Request

GET /characters/{character_id}/fleet/

Response

[body] => {"error":"Character ID mismatch between request path and auth token"}
[response_code] => 403

Expected

A unique error code for this condition, as there exists in the spec for 404: "The character is not in a fleet".
I suggest using the 409: Conflict response code for this case.

This almost certainly arose because of the FC choosing to SSO with the wrong character on their account, which would be mitigated by SSO issue/FR 10

@a-tal
Copy link
Contributor

a-tal commented Apr 17, 2018

this is a valid response. sso_status is not a required response attribute

@DaneelTrevize
Copy link
Author

DaneelTrevize commented Apr 17, 2018

Ok, can this exact error code be depended upon to remain, to be used as a case condition vs the other 403 responses previously experienced? If so, can it be documented in the spec?

Also, just noticed this occured at 2018-04-17 00:53:44 without X-Esi-Ab-Test, and at 2018-04-17 01:27:54 with:
X-Esi-Ab-Test: 1
X-Esi-Request-Id: 01b78af2-975c-491e-ba19-dfda5f5989ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants