Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the difference between /characters/{character_id}/planets/{planet_id}/pins.schematic_id and /characters/{character_id}/planets/{planet_id}/pins.factory_details.schematic_id ? #782

Open
deadlybulb opened this issue Mar 6, 2018 · 4 comments

Comments

@deadlybulb
Copy link
Contributor

Question

Planetary Interaction endpoint defines a pin with structure:

get_characters_character_id_planets_planet_id_pin {
  latitude (number): latitude number ,
  longitude (number): longitude number ,
  pin_id (integer): pin_id integer ,
  type_id (integer): type_id integer ,
  schematic_id (integer, optional): schematic_id integer ,
  extractor_details (get_characters_character_id_planets_planet_id_extractor_details, optional): 
  extractor_details object ,
  factory_details (get_characters_character_id_planets_planet_id_factory_details, optional): 
  factory_details object ,
  contents (Array[get_characters_character_id_planets_planet_id_content], optional): contents array ,
  install_time (string, optional): install_time string ,
  expiry_time (string, optional): expiry_time string ,
  last_cycle_start (string, optional): last_cycle_start string
}

Here schematic_id is optional. So far so good. However, there is an optional factory_details object which also defines a schematic_id. Is there a difference? Are they the same? Can one be present without the other?

@ghost
Copy link

ghost commented May 9, 2018

Hrm, this might be a straight up bug. Based on what I'm seeing it looks like the factory_details variation is never used. Has anyone ever seen a pin with a factory_details value?

@ghost ghost self-assigned this May 9, 2018
@deadlybulb
Copy link
Contributor Author

When I ported this bit for EveKit, only the top-level schematic_id was ever populated so I ended up ignoring factory details.

@EvilLivesHere
Copy link

I've also never noticed a pin with the factory_details object filled in. It seems to just populate the pin itself rather than add a sub object.

@warlof
Copy link
Contributor

warlof commented Apr 9, 2020

bump - for me it seems to be an inconsistency.

It seems the factory_details property is a duplicate of root level schematic_id property whereas factory_details is never used compared to schematic_id.

My suggestion would be to either remove factory_details part or improve the object by returning input/output and cycle information and remove the schematic_id from the root level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants