Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed but undelivered jobs does not have their status updated #752

Open
warlof opened this issue Feb 10, 2018 · 7 comments
Open

Completed but undelivered jobs does not have their status updated #752

warlof opened this issue Feb 10, 2018 · 7 comments

Comments

@warlof
Copy link
Contributor

warlof commented Feb 10, 2018

Bug

Completed but undelivered jobs does not have their status updated.
The two jobs bellow are ended for a while but has the status active

ready is expected

Request

https://esi.tech.ccp.is/latest/characters/91737895/industry/jobs/

Response

[
  {
    "job_id": 299121263,
    "installer_id": 91737895,
    "facility_id": 61000828,
    "station_id": 61000828,
    "activity_id": 1,
    "blueprint_id": 1021388600081,
    "blueprint_type_id": 3963,
    "blueprint_location_id": 61000828,
    "output_location_id": 61000828,
    "runs": 1,
    "status": "active",
    "duration": 28560,
    "start_date": "2016-06-25T08:02:00Z",
    "end_date": "2016-06-26T18:33:49Z",
    "cost": 271310,
    "licensed_runs": 3,
    "probability": 1,
    "product_type_id": 3962
  },
  {
    "job_id": 136257333,
    "installer_id": 91737895,
    "facility_id": 60002284,
    "station_id": 60002284,
    "activity_id": 3,
    "blueprint_id": 1006229093795,
    "blueprint_type_id": 2515,
    "blueprint_location_id": 60002284,
    "output_location_id": 60002284,
    "runs": 100,
    "status": "active",
    "duration": 600000,
    "start_date": "2012-04-03T16:28:59Z",
    "end_date": "2012-04-10T15:08:59Z",
    "licensed_runs": 0,
    "product_type_id": 2515
  }
]

Expected

[
  {
    "job_id": 299121263,
    "installer_id": 91737895,
    "facility_id": 61000828,
    "station_id": 61000828,
    "activity_id": 1,
    "blueprint_id": 1021388600081,
    "blueprint_type_id": 3963,
    "blueprint_location_id": 61000828,
    "output_location_id": 61000828,
    "runs": 1,
    "status": "ready",
    "duration": 28560,
    "start_date": "2016-06-25T08:02:00Z",
    "end_date": "2016-06-26T18:33:49Z",
    "cost": 271310,
    "licensed_runs": 3,
    "probability": 1,
    "product_type_id": 3962
  },
  {
    "job_id": 136257333,
    "installer_id": 91737895,
    "facility_id": 60002284,
    "station_id": 60002284,
    "activity_id": 3,
    "blueprint_id": 1006229093795,
    "blueprint_type_id": 2515,
    "blueprint_location_id": 60002284,
    "output_location_id": 60002284,
    "runs": 100,
    "status": "ready",
    "duration": 600000,
    "start_date": "2012-04-03T16:28:59Z",
    "end_date": "2012-04-10T15:08:59Z",
    "licensed_runs": 0,
    "product_type_id": 2515
  }
]
@GoldenGnu
Copy link
Member

The workaround that I have been using all the way back from Xml, is to check if “now” is after the completed date.

@panthernet
Copy link

Still relevant more than a year after?...

@rayanth
Copy link
Contributor

rayanth commented Jun 20, 2019

Still relevant more than a year after?...

The gears of change turn slowly, my friend...

@panthernet
Copy link

Well, yes. Also completed_date isn;t set when job is complete. Have to check end_date.

@GoldenGnu
Copy link
Member

@panthernet

completed_date isn't set when job is complete

I think you're wrong.

To the best of my knowledge completed_date is omitted until the job is completed, after that it return the date the job was completed.

end_date returns the expected end date of the job, that may change if the job is paused or otherwise changed after it is installed.

@panthernet
Copy link

@GoldenGnu I've tested this right away. I have 2 jobs which are ready and both of them is in active state with empty completed_date. Probably it is set when job is delivered but in this case the name is misleading.

@mdsantagithub
Copy link

I had several corp jobs completed, delivered.
Not returning with flag included_completed = false
and
NOT returning with flag included_completed = true.
Jobs were fresh at the time of Feb 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants