Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add include_completed to contracts! #607

Open
Yonneh0 opened this issue Oct 17, 2017 · 2 comments
Open

Feature Request: Add include_completed to contracts! #607

Yonneh0 opened this issue Oct 17, 2017 · 2 comments

Comments

@Yonneh0
Copy link

Yonneh0 commented Oct 17, 2017

for both /characters/{character_id}/contracts/ and /corporations/{corporation_id}/contracts/

Please add an include_completed boolean to the query string; that when set to false, only returns outstanding, in_progress contracts; and when true (or omitted) returns all contracts for the past 30 days (current logic)

in most applications, this can be used to reduce the number of results substantially. In my case, from processing ~5k results every 15 minutes, to processing ~10.

@Aidansavage
Copy link

Why not a "status=" field? This would give you the option to search for outstanding, in-progress, completed, or all contracts.

@Yonneh0
Copy link
Author

Yonneh0 commented Oct 17, 2017

that could work as well, but assumed that include_completed would be easier to implement, as it's already used on other endpoints. as long as status accepts multiple values (for example status=completed+in_progress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants