Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend shown contract age for outstanding contracts by issuer #1153

Open
3 of 8 tasks
E-351 opened this issue Nov 13, 2019 · 0 comments
Open
3 of 8 tasks

Extend shown contract age for outstanding contracts by issuer #1153

E-351 opened this issue Nov 13, 2019 · 0 comments

Comments

@E-351
Copy link

E-351 commented Nov 13, 2019

Feature Request

/characters/{character_id}/contracts/
/corporations/{corporation_id}/contracts/

Only returns contracts no older than 30 days, or if the status is "in_progress".

I'd like to see "outstanding" contracts to get the same treatment as "in_progress" (or at least take reasonably longer to disappear) for contracts where character/corporation is the issuer.

The maximum contract age is 28 days, after that it expires (while keeping status "outstanding") and it is still shown in game UI where player can delete it and receive back contract contents. Applications using this endpoint discover expired contracts simply through date_expired, however there are only two days for max age contracts when it's possible to discover whether player actually deleted the contract before it disappears from these endpoints. While you can simply assume they were deleted once they disappear from the endpoint it would be great if there was bigger window for player to react and application to know the contract was removed so it can notify user if not. The current behavior also causes issues with detecting free contract slots on your characters/corporations.

Use case

Industrialists who seed ships using contracts for their alliances.

Authentication

Existing routes & scopes:
esi-contracts.read_character_contracts.v1
esi-contracts.read_corporation_contracts.v1

Example return

n/a

Checklist

Check all boxes that apply to this issue:

  • Feature request description is provided
  • Use case exists
  • Feature requires a new route
  • Feature adds data to existing route
  • Feature requires new auth scope
  • Feature can reuse existing scope
  • Feature does not require auth
  • Meta feature, applies to all routes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants