Description
The current implementation in HostApplicationBuilderExtensions.Orleans.cs registers two default Orleans log consistency providers sequentially:
AddLogStorageBasedLogConsistencyProviderAsDefault()
AddStateStorageBasedLogConsistencyProviderAsDefault()
Since only one provider can be the default, the second call overrides the first. This needs to be revisited to properly configure a mixed approach where StateStorage is used for snapshots.
Context
This issue was identified during the code review of PR #5. The configuration needs refinement to support the intended mixed usage of both providers.
References
Suggested Resolution
Consider:
- Setting one provider as the default
- Registering the other as a named provider
- Configuring StateStorage specifically for snapshot functionality
Requested by: @snovak7
Description
The current implementation in
HostApplicationBuilderExtensions.Orleans.csregisters two default Orleans log consistency providers sequentially:AddLogStorageBasedLogConsistencyProviderAsDefault()AddStateStorageBasedLogConsistencyProviderAsDefault()Since only one provider can be the default, the second call overrides the first. This needs to be revisited to properly configure a mixed approach where StateStorage is used for snapshots.
Context
This issue was identified during the code review of PR #5. The configuration needs refinement to support the intended mixed usage of both providers.
References
HostingandAbstractionsprojects with initial dependencies and configuration #5HostingandAbstractionsprojects with initial dependencies and configuration #5 (comment)src/Hosting/HostApplicationBuilderExtensions.Orleans.cs(lines 37-44)Suggested Resolution
Consider:
Requested by: @snovak7