Skip to content
This repository was archived by the owner on Apr 14, 2023. It is now read-only.

Conversation

@apupier
Copy link
Contributor

@apupier apupier commented Jul 22, 2022

fixes #82

it allows to fix the build of the master branch.

fixes errata-ai#82

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier changed the title Align VS Code engine version with @types/vscode [To look first]Align VS Code engine version with @types/vscode Jul 22, 2022
@ChrisChinchilla
Copy link
Collaborator

@apupier I think #78 will do the same, but will merge this one too anyway, thanks!

@ChrisChinchilla ChrisChinchilla merged commit 12b7bcc into errata-ai:master Jul 27, 2022
@apupier apupier deleted the 82-fixBuild branch July 27, 2022 09:51
@apupier
Copy link
Contributor Author

apupier commented Jul 27, 2022

I think #78 will do the same, but will merge this one too anyway, thanks!

not sure. For now, the vs code engine is still at 1.43.0 and @types/vscode is using 1.69.0. This is detected only with vsce package, not when doing a "simple" compilation such as npm run compile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: @types/vscode ^1.59.0 greater than engines.vscode ^1.43.0. Consider upgrade engines.vscode or use an older @types/vscode version

2 participants