Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation on visual c++ #1

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Fix compilation on visual c++ #1

merged 2 commits into from
Jan 17, 2022

Conversation

tjachmann
Copy link
Contributor

No description provided.

erkkah
erkkah requested changes Jan 16, 2022
View reviewed changes
Copy link
Owner

@erkkah erkkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for the PR, and for making it build on VC++. I've not had a chance to test it myself, I'm glad it did not require that many changes.

@erkkah erkkah merged commit cf29304 into erkkah:main Jan 17, 2022
@erkkah
Copy link
Owner

erkkah commented Jan 17, 2022

Thanks again, @tjachmann !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erkkah erkkah erkkah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjachmann @erkkah