Replace fpm with dpkg-deb for DEB package generation (PowerShell#26281)

Copilot · web-flow · commit 7e1ef1f7448b · 2025-10-28T16:39:28.000-07:00
diff --git a/build.psm1 b/build.psm1
@@ -2234,43 +2234,6 @@ function Get-RedHatPackageManager {
     }
 }
 
-function Install-GlobalGem {
-    param(
-        [Parameter()]
-        [string]
-        $Sudo = "",
-
-        [Parameter(Mandatory)]
-        [string]
-        $GemName,
-
-        [Parameter(Mandatory)]
-        [string]
-        $GemVersion
-    )
-    try {
-        # We cannot guess if the user wants to run gem install as root on linux and windows,
-        # but macOs usually requires sudo
-        $gemsudo = ''
-        if($environment.IsMacOS -or $env:TF_BUILD -or $env:GITHUB_ACTIONS) {
-            $gemsudo = $sudo
-        }
-
-        Start-NativeExecution ([ScriptBlock]::Create("$gemsudo gem install $GemName -v $GemVersion --no-document"))
-
-    } catch {
-        Write-Warning "Installation of gem $GemName $GemVersion failed! Must resolve manually."
-        $logs = Get-ChildItem "/var/lib/gems/*/extensions/x86_64-linux/*/$GemName-*/gem_make.out" | Select-Object -ExpandProperty FullName
-        foreach ($log in $logs) {
-            Write-Verbose "Contents of: $log" -Verbose
-            Get-Content -Raw -Path $log -ErrorAction Ignore | ForEach-Object { Write-Verbose $_ -Verbose }
-            Write-Verbose "END Contents of: $log" -Verbose
-        }
-
-        throw
-    }
-}
-
 function Start-PSBootstrap {
     [CmdletBinding()]
     param(
@@ -2282,7 +2245,7 @@ function Start-PSBootstrap {
         [switch]$BuildLinuxArm,
         [switch]$Force,
         [Parameter(Mandatory = $true)]
-        # Package: Install dependencies for packaging tools (fpm, rpmbuild, WiX)
+        # Package: Install dependencies for packaging tools (rpmbuild, dpkg-deb, pkgbuild, WiX)
         # DotNet: Install the .NET SDK
         # Both: Package and DotNet scenarios
         # Tools: Install .NET global tools (e.g., dotnet-format)
@@ -2321,7 +2284,9 @@ function Start-PSBootstrap {
                 elseif ($environment.IsUbuntu18) { $Deps += "libicu60"}
 
                 # Packaging tools
-                if ($Scenario -eq 'Both' -or $Scenario -eq 'Package') { $Deps += "ruby-dev", "groff", "libffi-dev", "rpm", "g++", "make" }
+                # Note: ruby-dev, libffi-dev, g++, and make are no longer needed for DEB packaging
+                # DEB packages now use native dpkg-deb (pre-installed)
+                if ($Scenario -eq 'Both' -or $Scenario -eq 'Package') { $Deps += "groff", "rpm" }
 
                 # Install dependencies
                 # change the fontend from apt-get to noninteractive
@@ -2345,7 +2310,9 @@ function Start-PSBootstrap {
                 $Deps += "libicu", "openssl-libs"
 
                 # Packaging tools
-                if ($Scenario -eq 'Both' -or $Scenario -eq 'Package') { $Deps += "ruby-devel", "rpm-build", "groff", 'libffi-devel', "gcc-c++" }
+                # Note: ruby-devel and libffi-devel are no longer needed
+                # RPM packages use rpmbuild, DEB packages use dpkg-deb
+                if ($Scenario -eq 'Both' -or $Scenario -eq 'Package') { $Deps += "rpm-build", "groff" }
 
                 $PackageManager = Get-RedHatPackageManager
 
@@ -2366,7 +2333,8 @@ function Start-PSBootstrap {
                 $Deps += "wget"
 
                 # Packaging tools
-                if ($Scenario -eq 'Both' -or $Scenario -eq 'Package') { $Deps += "ruby-devel", "rpmbuild", "groff", 'libffi-devel', "gcc" }
+                # Note: ruby-devel and libffi-devel are no longer needed for packaging
+                if ($Scenario -eq 'Both' -or $Scenario -eq 'Package') { $Deps += "rpmbuild", "groff" }
 
                 $PackageManager = "zypper --non-interactive install"
                 $baseCommand = "$sudo $PackageManager"
@@ -2405,17 +2373,7 @@ function Start-PSBootstrap {
                 }
             }
 
-            # Install [fpm](https://github.com/jordansissel/fpm)
-            # Note: fpm is now only needed for DEB and macOS packages; RPM packages use rpmbuild directly
             if ($Scenario -in 'All', 'Both', 'Package') {
-                # Install fpm on Debian-based systems, macOS, and Mariner (where DEB packages are built)
-                if (($environment.IsLinux -and ($environment.IsDebianFamily -or $environment.IsMariner)) -or $environment.IsMacOS) {
-                    Install-GlobalGem -Sudo $sudo -GemName "dotenv" -GemVersion "2.8.1"
-                    Install-GlobalGem -Sudo $sudo -GemName "ffi" -GemVersion "1.16.3"
-                    Install-GlobalGem -Sudo $sudo -GemName "fpm" -GemVersion "1.15.1"
-                    Install-GlobalGem -Sudo $sudo -GemName "rexml" -GemVersion "3.2.5"
-                }
-
                 # For RPM-based systems, ensure rpmbuild is available
                 if ($environment.IsLinux -and ($environment.IsRedHatFamily -or $environment.IsSUSEFamily -or $environment.IsMariner)) {
                     Write-Verbose -Verbose "Checking for rpmbuild..."
@@ -2424,6 +2382,22 @@ function Start-PSBootstrap {
                         Start-NativeExecution -sb ([ScriptBlock]::Create("$sudo $PackageManager install -y rpm-build")) -IgnoreExitcode
                     }
                 }
+                
+                # For Debian-based systems and Mariner, ensure dpkg-deb is available
+                if ($environment.IsLinux -and ($environment.IsDebianFamily -or $environment.IsMariner)) {
+                    Write-Verbose -Verbose "Checking for dpkg-deb..."
+                    if (!(Get-Command dpkg-deb -ErrorAction SilentlyContinue)) {
+                        Write-Warning "dpkg-deb not found. Installing dpkg package..."
+                        if ($environment.IsMariner) {
+                            # For Mariner (Azure Linux), install the extended repo first to access dpkg.
+                            Write-Verbose -Verbose "Installing azurelinux-repos-extended for Mariner..."
+                            Start-NativeExecution -sb ([ScriptBlock]::Create("$sudo $PackageManager install -y azurelinux-repos-extended")) -IgnoreExitcode
+                            Start-NativeExecution -sb ([ScriptBlock]::Create("$sudo $PackageManager install -y dpkg")) -IgnoreExitcode
+                        } else {
+                            Start-NativeExecution -sb ([ScriptBlock]::Create("$sudo apt-get install -y dpkg")) -IgnoreExitcode
+                        }
+                    }
+                }
             }
         }
 
diff --git a/test/packaging/linux/package-validation.tests.ps1 b/test/packaging/linux/package-validation.tests.ps1
@@ -21,10 +21,7 @@ Describe "Linux Package Name Validation" {
         It "Should have valid RPM package names" {
             $rpmPackages = Get-ChildItem -Path $artifactsDir -Recurse -Filter *.rpm -ErrorAction SilentlyContinue
             
-            if ($rpmPackages.Count -eq 0) {
-                Set-ItResult -Skipped -Because "No RPM packages found in artifacts directory"
-                return
-            }
+            $rpmPackages.Count | Should -BeGreaterThan 0 -Because "At least one RPM package should exist in the artifacts directory"
             
             $invalidPackages = @()
             # Regex pattern for valid RPM package names.
@@ -49,19 +46,50 @@ Describe "Linux Package Name Validation" {
             if ($invalidPackages.Count -gt 0) {
                 throw ($invalidPackages | Out-String)
             }
+        }
+    }
+    
+    Context "DEB Package Names" {
+        It "Should have valid DEB package names" {
+            $debPackages = Get-ChildItem -Path $artifactsDir -Recurse -Filter *.deb -ErrorAction SilentlyContinue
+            
+            $debPackages.Count | Should -BeGreaterThan 0 -Because "At least one DEB package should exist in the artifacts directory"
+            
+            $invalidPackages = @()
+            # Regex pattern for valid DEB package names.
+            # Valid examples:
+            # - powershell-preview_7.6.0-preview.6-1.deb_amd64.deb
+            # - powershell-lts_7.4.13-1.deb_amd64.deb
+            # - powershell_7.4.13-1.deb_amd64.deb
+            # Breakdown:
+            # ^powershell            : Starts with 'powershell'
+            # (-preview|-lts)?       : Optionally '-preview' or '-lts'
+            # _\d+\.\d+\.\d+         : Underscore followed by version number (e.g., _7.6.0)
+            # (-[a-z]+\.\d+)?        : Optional dash, letters, dot, and digits (e.g., -preview.6)
+            # -1                     : Literal '-1'
+            # \.deb_                 : Literal '.deb_'
+            # (amd64|arm64)          : Architecture
+            # \.deb$                 : File extension
+            $debPackageNamePattern = '^powershell(-preview|-lts)?_\d+\.\d+\.\d+(-[a-z]+\.\d+)?-1\.deb_(amd64|arm64)\.deb$'
+
+            foreach ($package in $debPackages) {
+                if ($package.Name -notmatch $debPackageNamePattern) {
+                    $invalidPackages += "$($package.Name) is not a valid DEB package name"
+                    Write-Warning "$($package.Name) is not a valid DEB package name"
+                }
+            }
             
-            $rpmPackages.Count | Should -BeGreaterThan 0
+            if ($invalidPackages.Count -gt 0) {
+                throw ($invalidPackages | Out-String)
+            }
         }
     }
     
     Context "Tar.Gz Package Names" {
         It "Should have valid tar.gz package names" {
             $tarPackages = Get-ChildItem -Path $artifactsDir -Recurse -Filter *.tar.gz -ErrorAction SilentlyContinue
             
-            if ($tarPackages.Count -eq 0) {
-                Set-ItResult -Skipped -Because "No tar.gz packages found in artifacts directory"
-                return
-            }
+            $tarPackages.Count | Should -BeGreaterThan 0 -Because "At least one tar.gz package should exist in the artifacts directory"
             
             $invalidPackages = @()
             foreach ($package in $tarPackages) {
@@ -76,8 +104,6 @@ Describe "Linux Package Name Validation" {
             if ($invalidPackages.Count -gt 0) {
                 throw ($invalidPackages | Out-String)
             }
-            
-            $tarPackages.Count | Should -BeGreaterThan 0
         }
     }
     
diff --git a/tools/packaging/packaging.psm1 b/tools/packaging/packaging.psm1
