Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon mapping for OpenWeather codes 803 & 804 #243

Open
dtenglish opened this issue Apr 13, 2021 · 0 comments
Open

Icon mapping for OpenWeather codes 803 & 804 #243

dtenglish opened this issue Apr 13, 2021 · 0 comments

Comments

@dtenglish
Copy link

The api mapping for OpenWeather doesn't correctly adjust for day/night on codes 803 and 804, instead pointing to same icon as the neutral mapping.

Neutral:

.wi-owm-803:before {
  content: "\f013";
}
.wi-owm-night-804:before {
  content: "\f013";
}

Day:

.wi-owm-day-803:before {
  content: "\f013";
}
.wi-owm-day-804:before {
  content: "\f013";
}

Night:

.wi-owm-night-803:before {
  content: "\f013";
}
.wi-owm-night-804:before {
  content: "\f013";
}

I believe day should be using f002 and night should be using f086.

Additionally, for consistency with the night icon, I believe the mapping for .wi-owm-day-801 should be changed to icon f00c.

@dtenglish dtenglish changed the title Icon mapping for OpenWeather code 803 Icon mapping for OpenWeather codes 803 & 804 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant