Switch execution to evmone baseline interpreter #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
- Coverage 81.82% 81.78% -0.05%
==========================================
Files 170 169 -1
Lines 14196 14206 +10
==========================================
+ Hits 11616 11618 +2
- Misses 2580 2588 +8
Continue to review full report at Codecov.
|
yperbasis
changed the title
yperbasis
requested review from
AndreaLanfranchi,
canepat,
chfast and
mriccobene
| @@ -84,7 +84,8 @@ StageResult Execution::forward(db::RWTxn& txn) { | |||
| prune_receipts = std::min(prune_receipts, hashstate_stage_progress - 1); | |||
| } | |||
|
|
|||
| AnalysisCache analysis_cache; | |||
| static constexpr size_t kCacheSize{5'000}; | |||
| lru_cache<evmc::bytes32, std::shared_ptr<evmone::baseline::CodeAnalysis>> analysis_cache{kCacheSize}; | |||
There was a problem hiding this comment.
I don't get this. Isn't lru_cache<evmc::bytes32, std::shared_ptr<evmone::baseline::CodeAnalysis>> the cache_ member of AdvancedAnalysisCache class ?
There was a problem hiding this comment.
No, in AdvancedAnalysisCache it's lru_cache<evmc::bytes32, std::shared_ptr<evmone::advanced::AdvancedCodeAnalysis>>
There was a problem hiding this comment.
I'll introduce a type alias for clarity.
AndreaLanfranchi
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching execution from advanced to baseline evmone interpreter results in performance saving of about 1h (out of circa 1day) of the execution time. One contributing factor, I think, is that baseline
CodeAnalysisis more compact thanAdavancedCodeAnalysis, so the cache is significantly smaller and thus more RAM is available for MDBX page caching by the OS.linux-x86_64, gcc 11.2.0