Split libsilkworm into silkworm_core & silkworm_db #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AndreaLanfranchi Sure, thank you! |
|
@yperbasis looks good to me too. I still get a lot of warnings though mainly due to CXX17 deprecations on subprojects: abseil cbor and mdb.c mainly |
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 84.09% 83.26% -0.84%
==========================================
Files 51 54 +3
Lines 3848 3920 +72
==========================================
+ Hits 3236 3264 +28
- Misses 612 656 +44
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential Ethereum protocol logic will live in core (block execution, RLP, root hash algorithms, etc), while silkworm_db will contain LMDB access logic and TG-specific things. The reason is two-fold. First, a smaller core library will make Silkworm easier to use for things like eth_call, where TG & LMDB paraphernalia is not required. Second, the smaller core can potentially be compiled into WebAssembly, which is a strategic goal for us (in particular for the Internet Computer project by Dfinity).