rpc/transactions: propagate AsMessage error in ComputeTxContext #18083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures ComputeTxContext correctly surfaces failures from txn.AsMessage (e.g., invalid signature or tx type not permitted by current fork rules) instead of proceeding with an invalid message and returning a nil error. Downstream consumers (e.g., jsonrpc tracing and otterscan tracing paths) already expect an error-returning ComputeTxContext and construct TxContext from a valid Message; by propagating the error we prevent building inconsistent EVM contexts (wrong Origin/GasPrice/BlobHashes) and align behavior with other call sites that properly check AsMessage errors like overlay_api and trace_worker. This is a correctness fix for tracing semantics and does not affect AA txs whose AsMessage does not error.