Improve Msg.Discard Error Handling to Prevent DoS
#18049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2025
anacrolix
pushed a commit
that referenced
this pull request
Dec 2, 2025
seems #18049 is important - but i think it's big and controversial - likely will take time to think/merge it. So, here is minimalistic version of that PR.
anacrolix
pushed a commit
that referenced
this pull request
Dec 2, 2025
seems #18049 is important - but i think it's big and controversial - likely will take time to think/merge it. So, here is minimalistic version of that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Msg.Discardto return errors instead of callinglog.Fatal, avoiding node-wide crashes on malformed payloads.p2pconsumers (peer handling, sentry handshake/server, tests) with precise diagnostics.go test ./p2p/...passes to validate the change.