Skip to content

Commit 1a050db

Browse files
authored
eth/tracers: always pop precompiles stack in callTracer (#11004)
made a mistake in previous PR #10986 should always pop the precompiles stack for correctness
1 parent 9710e98 commit 1a050db

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

eth/tracers/native/call.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,13 @@ func (t *callTracer) CaptureExit(output []byte, gasUsed uint64, err error) {
251251
return
252252
}
253253
precompilesLastIdx := len(t.precompiles) - 1
254-
if !t.config.IncludePrecompiles && precompilesLastIdx > -1 && t.precompiles[precompilesLastIdx] {
255-
t.precompiles = t.precompiles[:precompilesLastIdx]
254+
if precompilesLastIdx < 0 {
255+
return
256+
}
257+
// pop precompile
258+
precompile := t.precompiles[precompilesLastIdx]
259+
t.precompiles = t.precompiles[:precompilesLastIdx]
260+
if precompile && !t.config.IncludePrecompiles {
256261
return
257262
}
258263
// pop call

0 commit comments

Comments
 (0)