Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

back button on annotated bibliography page returns user to keywords page #182

Open
nkmeyers opened this issue Jun 15, 2021 · 3 comments
Open
Assignees
Labels
bug Something isn't working carrel Something to do with the generated carrel pages

Comments

@nkmeyers
Copy link
Collaborator

If I hit the back button on the annotated bibliography page to return to the "bibliographics" page I am instead returned to the "keywords" page . This is unexpected and dumps user to a page they may not have even visited yet? Not quite sure why or even how that works that way?

@nkmeyers nkmeyers added the bug Something isn't working label Jun 15, 2021
@dbrower
Copy link
Collaborator

dbrower commented Jun 16, 2021

This seems to be only on CORD carrels?

Steps to reproduce:

  1. Visit "bibliographics" page (in top left drop down menu). e.g. https://distantreader.org/p/carrels/journal-actaPharmacolSin-cord/htm/bibliographics.htm
  2. click "here" to see to see an annotated bibliography
  3. choose browser "back" button

@dbrower
Copy link
Collaborator

dbrower commented Jun 16, 2021

The "page" that appears giving an annotated bibliography is really a pop-up window. So hitting the back button takes you to the page you were on when selecting the "bibliographics" link.

Also it seems different searches generate different html files and some don't have this problem.

@dbrower
Copy link
Collaborator

dbrower commented Jun 16, 2021

The HTML for this page is generated on the compute side. I have been trying to not touch any of the compute code. Also, there are three forks of the compute code, so changes need to be made on each fork. Lastly, changing the compute code does not change the HTML in the carrels already created.

@ericleasemorgan do you have any thoughts on these three points? Is it ok if I change the compute code? do you have a way to deploy my changes to the compute nodes? How should HTML bugs in already created carrels be handled?

@dbrower dbrower added the carrel Something to do with the generated carrel pages label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working carrel Something to do with the generated carrel pages
Projects
None yet
Development

No branches or pull requests

2 participants