Skip to content

merge QuoInt and Rem into QuoRem. #73

Open

Description

@ericlagergren

The GDA spec says Rem should fail in the same ways as QuoInt, which means literally in the same ways. Since this means we (effectively) cannot optimize QuoInt and Rem to reduce computations, for code clarity we should just merge the two into QuoRem.

Activity

  1. changed the title [-]Squash QuoInt and Rem into QuoRem.[/-] [+]Merge QuoInt and Rem into QuoRem.[/+] on Jan 29, 2018
  2. changed the title [-]Merge QuoInt and Rem into QuoRem.[/-] [+]merge QuoInt and Rem into QuoRem.[/+] on Mar 24, 2018
  3. kentquirk commented on Jul 2, 2018

    @kentquirk

    Are you saying that you want to eliminate QuoInt and Rem entirely (which would be a breaking API change), or are you saying that the implementations of QuoInt and Rem should be converted to calls to QuoRem with a discarded value?

  4. ericlagergren commented on Jul 2, 2018

    @ericlagergren
    OwnerAuthor

    @kentquirk Yeah, converted to calls to QuoRem with a discarded value.

    Looking at #72, I'm not entirely sure this is still necessary. It's been 6 months since I created it so I'll have to reinvestigate. But yeah, no API breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions