Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge QuoInt and Rem into QuoRem. #73

Open
ericlagergren opened this issue Jan 29, 2018 · 2 comments
Open

merge QuoInt and Rem into QuoRem. #73

ericlagergren opened this issue Jan 29, 2018 · 2 comments

Comments

@ericlagergren
Copy link
Owner

The GDA spec says Rem should fail in the same ways as QuoInt, which means literally in the same ways. Since this means we (effectively) cannot optimize QuoInt and Rem to reduce computations, for code clarity we should just merge the two into QuoRem.

@ericlagergren ericlagergren changed the title Squash QuoInt and Rem into QuoRem. Merge QuoInt and Rem into QuoRem. Jan 29, 2018
@ericlagergren ericlagergren self-assigned this Jan 29, 2018
@ericlagergren ericlagergren changed the title Merge QuoInt and Rem into QuoRem. merge QuoInt and Rem into QuoRem. Mar 24, 2018
@kentquirk
Copy link

Are you saying that you want to eliminate QuoInt and Rem entirely (which would be a breaking API change), or are you saying that the implementations of QuoInt and Rem should be converted to calls to QuoRem with a discarded value?

@ericlagergren
Copy link
Owner Author

@kentquirk Yeah, converted to calls to QuoRem with a discarded value.

Looking at #72, I'm not entirely sure this is still necessary. It's been 6 months since I created it so I'll have to reinvestigate. But yeah, no API breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants