Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearLayout Support - loading skeleton messes recycler view orders in parent view. #13

Open
TurKurT656 opened this issue Jul 21, 2020 · 3 comments
Labels
💎 feature New feature or request

Comments

@TurKurT656
Copy link

First of all, Thank you for your fast bugfixes. I appreciate that.
I'll try to help you with reporting bugs and as soon as I can, I will contribute on the lib.

About this issue, take this layout hierarchy:

<androidx.core.widget.NestedScrollView
            android:layout_width="match_parent"
            android:layout_height="match_parent">

            <LinearLayout
                android:layout_width="match_parent"
                android:layout_height="wrap_content"
                android:orientation="vertical">

                <androidx.recyclerview.widget.RecyclerView
                    android:id="@+id/rv_first"
                    android:layout_width="match_parent"
                    android:layout_height="wrap_content" />

                <androidx.recyclerview.widget.RecyclerView
                    android:id="@+id/rv_second"
                    android:layout_width="match_parent"
                    android:layout_height="wrap_content" />

            </LinearLayout>

 </androidx.core.widget.NestedScrollView>

So when I try to call .loadSkeleton() function on both of the RecyclerViews their order changes. so on loading state the first RV shows at bottom and the second one shows at the top.

@TurKurT656 TurKurT656 changed the title [Bug Report] - [Bug Report] - loading skeleton messes recycler view orders in parent view. Jul 21, 2020
@TurKurT656
Copy link
Author

I found the problem. The issue is coming from LinearLayout. I've changed the container to ConstraintLayout and problem fixed. Any idea why LinearLayout has problem with this lib?

@ericktijerou
Copy link
Owner

Hi!, @TurKurT656. Sorry for late reply.

LinearLayouts are not yet supported!!. You can use another ViewGroup. For example ConstraintLayout, just like you said.

I'll be working in this new feature.

Thanks a lot! ✌️ ✌️

@ericktijerou ericktijerou added the 💎 feature New feature or request label Jul 30, 2020
@ericktijerou ericktijerou changed the title [Bug Report] - loading skeleton messes recycler view orders in parent view. LinearLayout Support - loading skeleton messes recycler view orders in parent view. Jul 30, 2020
@drianmr
Copy link

drianmr commented May 18, 2021

Any updates for this issue? Using FlexboxLayout is also messes the recycler view orders. Also, I have to convert all recycler view parents to another ViewGroup only to temporarily fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants