Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErickSkrauch/align_multiline_parameters not working correctly with union types #6

Closed
yarikhalupiak opened this issue Jan 5, 2024 · 2 comments
Closed

ErickSkrauch/align_multiline_parameters not working correctly with union types #6

yarikhalupiak opened this issue Jan 5, 2024 · 2 comments
Assignees
@erickskrauch
Labels
bug Something isn't working

Comments

@yarikhalupiak
Copy link

yarikhalupiak commented Jan 5, 2024 •
edited
Loading

Hi @erickskrauch

The current logic for calculating the length of a type does not consider php8 union types. Could you please let know if you plan to include similar logic?

#5
@yarikhalupiak yarikhalupiak changed the title Added type length calculation for union types Add type length calculation for union types Jan 5, 2024
@yarikhalupiak yarikhalupiak changed the title Add type length calculation for union types ErickSkrauch/align_multiline_parameters ot working correctly with union types Jan 5, 2024
@yarikhalupiak yarikhalupiak changed the title ErickSkrauch/align_multiline_parameters ot working correctly with union types ErickSkrauch/align_multiline_parameters not working correctly with union types Jan 5, 2024
@erickskrauch erickskrauch self-assigned this Jan 6, 2024
@erickskrauch erickskrauch added the bug Something isn't working label Jan 6, 2024
@erickskrauch
Copy link
Owner

This fixer also must support both intersections and unions:

  • A|B
  • A|(B&C)

@erickskrauch
Copy link
Owner

@yarikhalupiak, released in 1.2.2. Thank you for the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erickskrauch erickskrauch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

complex_types_support erickskrauch/php-cs-fixer-custom-fixers
2 participants
@erickskrauch @yarikhalupiak