Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reloading #216

Closed
pablopaul opened this issue Apr 15, 2016 · 6 comments
Closed

Hot reloading #216

pablopaul opened this issue Apr 15, 2016 · 6 comments

Comments

@pablopaul
Copy link
Contributor

What is the actual implementation state of the "hot reloading" feature in this repo? A fresh install of the repo shows the following console output after a file change:

[HMR] connected
client.js:123 [HMR] bundle rebuilding
client.js:126 [HMR] bundle rebuilt in 450ms
process-update.js:27 [HMR] Checking for updates on the server...
process-update.js:81 [HMR] The following modules couldn't be hot updated: (Full reload needed)
This is usually because the modules which have changed (and their parents) do not know how to hot reload themselves. See http://webpack.github.io/docs/hot-module-replacement-with-webpack.html for more details.
process-update.js:89 [HMR]  - ./source/index.js
@ericelliott
Copy link
Owner

HMR doesn't work with pure components. );

We should remove the feature. Want to PR?

@pablopaul
Copy link
Contributor Author

Can you give some context why HMR is not working with pure components?

Yes I will make a PR.

@ericelliott
Copy link
Owner

It's a known issue with HMR in general. Discussion is here.

@gaearon
Copy link

gaearon commented Apr 18, 2016

React Hot Loader 3 supports functional components without destroying the state.
It supersedes both React Hot Loader and React Transform, and is built on lessons learned from both.
Check it out: gaearon/react-hot-boilerplate#61

@pablopaul
Copy link
Contributor Author

@ericelliott I suggest we are waiting for React Hot Loader 3, right?

@gaearon
Copy link

gaearon commented Apr 18, 2016

Note it might take quite a while to release as stable because I have no time to work on docs or website right now. Those are the blockers. See gaearon/react-hot-loader#243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants