Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log targets : A minimal remediation for Issue #4 #5

Merged
merged 2 commits into from
Aug 4, 2013
Merged

Log targets : A minimal remediation for Issue #4 #5

merged 2 commits into from
Aug 4, 2013

Conversation

lorefnon
Copy link

@lorefnon lorefnon commented Aug 1, 2013

No description provided.

ericclemmons added a commit that referenced this pull request Aug 4, 2013
Log targets : A minimal remediation for Issue #4
@ericclemmons ericclemmons merged commit c3e36be into ericclemmons:master Aug 4, 2013
@vegetabill
Copy link
Contributor

Could you add a flag for this logging?

Maybe only log if verbose: true or offer a quiet: true override.

It's a bit noisy and I usually don't want to see it.

Happy to create a PR if you accept the change but don't have time to implement.

@ericclemmons
Copy link
Owner

@RearAdmiral I agree, this is verbose. Can you submit a PR for verbose: true (verbosity should be opted into, IMO)? I'm short on time nowadays :(

Thanks!

@vegetabill
Copy link
Contributor

Sounds good. Split into #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants