Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Browser extension with Plasmo #56

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP] Browser extension with Plasmo #56

wants to merge 6 commits into from

Conversation

ericclemmons
Copy link
Owner

Plasmo has mostly been good, but I've ran into significant storage/syncing issues between the popup.tsx and content.tsx:

Kapture.2022-06-23.at.11.47.28.mp4

I've tried permutations of setRenderValue+setStoreValue, remove(), and everything else.

It just seems that there's a race-condition with storage. I started this ~2 weeks ago before vacation, ran into this same problem, and spent another 2 hours trouble-shooting it today.

setTimeout solves the race-condition to a degree, but I can't find a reliable number to use.

@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2022

⚠️ No Changeset found

Latest commit: 2fdc120

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant