Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting maximum-scale in viewport meta has long been considered bad. #13

Closed
tomliv opened this issue Feb 6, 2019 · 1 comment
Closed

Comments

@tomliv
Copy link

tomliv commented Feb 6, 2019

Describe the bug
Setting maximum-scale in viewport meta has long been considered bad. It prevents users from being able to pinch-zoom should they need to.

To Reproduce
See the outputted html
look at meta tag for viewport:

Expected behavior
Should be:

Desktop (please complete the following information):

  • OS: [e.g. iOS]
    All
  • Browser [e.g. chrome, safari]
    All
  • Version [e.g. 22]
    All

Additional context
https://a11yproject.com/posts/never-use-maximum-scale/

@ericalli
Copy link
Owner

Hey @tomliv,

Agreed! Feel free to submit a PR for this and I'll get it merged in ASAP. Otherwise, I'll get to it as soon as I have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants