Make SetProxy behave like curl's CURLOPT_PROXY

this changes the behaviour of SetProxy from just returning on an empty
string to assigning it. This emulates the curl behaviour of disabling
the proxy on an empty string.

fixes mrtazz#73

Author: mrtazz

source/connection.cc

@@ -249,16 +249,13 @@ RestClient::Connection::SetKeyPassword(const std::string& keyPassword) {
  */
 void
 RestClient::Connection::SetProxy(const std::string& uriProxy) {
-  if (uriProxy.empty()) {
-    return;
-  }
 
   std::string uriProxyUpper = uriProxy;
   // check if the provided address is prefixed with "http"
   std::transform(uriProxyUpper.begin(), uriProxyUpper.end(),
     uriProxyUpper.begin(), ::toupper);
 
-  if (uriProxyUpper.compare(0, 4, "HTTP") != 0) {
+  if ((uriProxy.length() > 0) && (uriProxyUpper.compare(0, 4, "HTTP") != 0)) {
     this->uriProxy = "http://" + uriProxy;
   } else {
     this->uriProxy = uriProxy;

test/test_connection.cc

@@ -224,6 +224,14 @@ TEST_F(ConnectionTest, TestProxy)
   EXPECT_EQ(200, res.code);
 }
 
+TEST_F(ConnectionTest, TestUnSetProxy)
+{
+  conn->SetProxy("127.0.0.1:3128");
+  conn->SetProxy("");
+  RestClient::Response res = conn->get("/get");
+  EXPECT_EQ(200, res.code);
+}
+
 TEST_F(ConnectionTest, TestProxyAddressPrefixed)
 {
   conn->SetProxy("http://127.0.0.1:3128");