feat: NitroRPC app implementation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philanton
force-pushed
the
feat/nitro-rpc-app
branch
from
849e85a to
baae394
Compare
nksazonov
reviewed
Mar 13, 2025
nksazonov
reviewed
Mar 13, 2025
Comment on lines
+47
to
+50
| PayloadSigned memory payloadSigned = abi.decode(candidate.variablePart.appData, (PayloadSigned)); | ||
| requireValidPayload(fixedPart, payloadSigned); | ||
|
|
||
| return (true, ""); |
There was a problem hiding this comment.
Do we have any other checks pertaining to Payload? Should payloads be chained, in which case we should introduce proof checks?
* feat: nitro-rpc proto and golang draft implementation * feat: add compatibility tests for signing * forge install: openzeppelin-contracts v5.2.0 * import openzeppelin contracts * fix: packing and signing * add questions * Update README.md * Update README.md * Descriptiong NitroRPC convention * Fixed todolist * Update headers * nitro client api overview --------- Co-authored-by: Louis <mod@yellow.org>
Funding, and Finalize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.