Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<surplus> in logical display #305

Closed
arlogriffiths opened this issue May 18, 2024 · 4 comments
Closed

<surplus> in logical display #305

arlogriffiths opened this issue May 18, 2024 · 4 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@arlogriffiths
Copy link
Collaborator

I have this chunk of code:

tinaḍaḥ rakryān· mahāmantrī I hino śrī samaravijaya <surplus>dha<lb break="no" n="B3"/>ma</surplus> suparṇa<unclear>vā</unclear>haṇa tguh uttuṅgadeva,

I wasn't sure whether I could wrap <surplus> around a chunk interrupted by <lb> but it doesn't cause any invalidation problem so at first sight I thought it was fine.

But when I see the display, I am not sure I approve of the segment encoded as superfluous being entirely invisible in logical display; and it can certainly not be our intention for this particular <lb> to become invisible in the same process.

Capture d’écran 2024-05-18 à 09 19 04 Capture d’écran 2024-05-18 à 09 18 39

I'd prefer {dhama} and the line beginning to be shown in both logical and physical display.

@manufrancis
Copy link
Collaborator

I concur with Arlo

@danbalogh
Copy link
Collaborator

According to our present encoding rules, <surplus> must be split across the line break. The correct encoding is <surplus>dha</surplus><lb break="no" n="B3"/><surplus>ma</surplus> and anything else should be flagged as an error by the schema. See #304 for the details.

@danbalogh danbalogh reopened this May 21, 2024
@arlogriffiths
Copy link
Collaborator Author

Thanks for the clarification. Encoding updated.

I'll let @michaelnmmeyer close this again once he feels it's time.

@michaelnmmeyer
Copy link
Member

Closing this as this is covered by #304.

@michaelnmmeyer michaelnmmeyer closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

4 participants