-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let schema propose values for some attributes #295
Comments
With the toolchain we are using, autocomplete only works for attributes that have a finite set of values. In our schema, we have about thirty attributes that do not, among which the ones you mentioned. Now, some of them are probably supposed to have restricted values, e.g. |
Thanks Michaël. The specific values I have been finding annoying to have to type out myself are |
@michaelnmmeyer : I see that the values of @type on |
I notice that the schema now suggests "eccentric_ductus" and "illegible" for values of |
I do not find any mention of
Should I drop the attribute from these files? |
I thought it occurred only in the siddham backup files. We may have endorsed this usage in some very early incarnation of the EGD. As for dropping the attribute from the files, you can certainly go ahead and do that for the Bengal Charters files (I've checked those, and all are based on earlier Siddham files, so this must be a legacy that was not updated to Dharma standards). It's probably OK to remove it from the Tiruvavatuturai file too, but I'm not sure about the Indonesian manuscript editions. @arlogriffiths , can you tell us whether it's OK to replace the erroneous
By the way, I see many instances of |
Looking at my own notes, I kept the value |
Still, I would prefer if none of our files had it explicitly. And if a default value is essential for good practice, then I think it had better be "damage". "Unclear because it is illegible" is, after all, a sort of tautology. |
Zaki has jusr corrected his file texts/DHARMA_DiplEdCandrakiranaPerpusnasL241.xml. @aditiagunawan : could you please correct your files by changing |
@danbalogh : if the SIDDHAM hack is going to be made unavailable, will you make all the necessary manual adjustments in the SIDDHAM files? |
The Siddham files have all been adjusted a long time ago without manual checking. They now have |
I believe this issue can be closed. |
@michaelnmmeyer
At the moment, the EGD-based schema does not yet propose permissible values for a number of attributes.
I have noted:
<unclear>
: no values are proposed for @Reason<seg>
: no values are proposed for @type and @subtypeIs it possible for the schema to systematically propose the admitted values for given attributes?
The text was updated successfully, but these errors were encountered: