Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let schema propose values for some attributes #295

Open
arlogriffiths opened this issue Apr 28, 2024 · 12 comments
Open

let schema propose values for some attributes #295

arlogriffiths opened this issue Apr 28, 2024 · 12 comments
Assignees
Labels
enhancement New feature or request

Comments

@arlogriffiths
Copy link
Collaborator

@michaelnmmeyer

At the moment, the EGD-based schema does not yet propose permissible values for a number of attributes.

I have noted:

  1. <unclear>: no values are proposed for @Reason
  2. <seg>: no values are proposed for @type and @subtype

Is it possible for the schema to systematically propose the admitted values for given attributes?

@arlogriffiths arlogriffiths added the enhancement New feature or request label Apr 28, 2024
@michaelnmmeyer
Copy link
Member

With the toolchain we are using, autocomplete only works for attributes that have a finite set of values. In our schema, we have about thirty attributes that do not, among which the ones you mentioned.

Now, some of them are probably supposed to have restricted values, e.g. unclear/@reason. I will review the list with the EGD to try to spot them. For the others, e.g. milestone/@unit, I will have to find a workaround, which will take some time.

@arlogriffiths
Copy link
Collaborator Author

Thanks Michaël. The specific values I have been finding annoying to have to type out myself are

  • "eccentric_ductus" for @Reason on <unclear> (I think there are no other admitted values for @Reason on this element)
  • "component", "body" and "aksara" for @type on <seg> (I think there not many other admitted values for @type on @type this element)

@arlogriffiths
Copy link
Collaborator Author

@michaelnmmeyer : I see that the values of @type on <unclear> are now proposed by the schema. Have all other parts of this issue also been dealt with? If so, you could close it.

@danbalogh
Copy link
Collaborator

I notice that the schema now suggests "eccentric_ductus" and "illegible" for values of unclear/@reason and when there's a different value entered, the error message says says that these are the permitted values. I think that "illegible" was a permitted value only in Siddham as a hack for the concept of "supplied reason illegible", which EpiDoc does not permit (see EGD §5.1), but we have chosen not to use this in DHARMA and stick to proper EpiDoc, so "illegible" should be removed from the list of permitted values, leaving only "eccentric_ductus".
Or is there some provision in the EGD for <unclear reason="illegible"> that I have forgotten about and cannot find now?

@michaelnmmeyer
Copy link
Member

I do not find any mention of unclear/@reason="illegible" in the EGD (nor in the EGC, for that matter). There are still a few texts that use it, maybe because it is incorrectly treated as valid:

>>> texts/DHARMA_DiplEdCandrakiranaPerpusnasL241.xml
>>> texts/DHARMA_DiplEdSiksaGuruPerpusnasL633.xml
>>> texts/DHARMA_DiplEdSiksaKandangKaresianPerpusnasL624.xml
>>> texts/DHARMA_DiplEdSiksaKandangKaresianPerpusnasL630.xml
>>> texts/DHARMA_INSBengalCharters00001.xml
>>> texts/DHARMA_INSBengalCharters00031.xml
>>> texts/DHARMA_INSBengalCharters00032.xml
>>> texts/DHARMA_INSBengalCharters00033.xml
>>> texts/DHARMA_INSBengalCharters00034.xml
>>> texts/DHARMA_INSBengalCharters00052.xml
>>> texts/DHARMA_INSBengalCharters00084.xml
>>> texts/DHARMA_INSTiruvavatuturai00003.xml

Should I drop the attribute from these files?

@michaelnmmeyer michaelnmmeyer reopened this Jul 2, 2024
@danbalogh
Copy link
Collaborator

I thought it occurred only in the siddham backup files. We may have endorsed this usage in some very early incarnation of the EGD.
At any rate, please remove it from the schema.

As for dropping the attribute from the files, you can certainly go ahead and do that for the Bengal Charters files (I've checked those, and all are based on earlier Siddham files, so this must be a legacy that was not updated to Dharma standards). It's probably OK to remove it from the Tiruvavatuturai file too, but I'm not sure about the Indonesian manuscript editions.

@arlogriffiths , can you tell us whether it's OK to replace the erroneous <unclear reason="illegible"> to <unclear> in these four editions? Or if uncertain, can you urge Zaki (and/or whoever is in charge of those files) to check the occurrences and correct to <unclear> or <supplied reason="lost"> on a case-by-case basis?

>>> texts/DHARMA_DiplEdCandrakiranaPerpusnasL241.xml
>>> texts/DHARMA_DiplEdSiksaGuruPerpusnasL633.xml
>>> texts/DHARMA_DiplEdSiksaKandangKaresianPerpusnasL624.xml
>>> texts/DHARMA_DiplEdSiksaKandangKaresianPerpusnasL630.xml

By the way, I see many instances of <unclear reason="blackened"> in DiplEdCandrakiranaPerpusnasL241. If this is a usage endorsed by the EGC, then that should probably be added to the schema-permitted values of reason on unclear.

@michaelnmmeyer
Copy link
Member

Looking at my own notes, I kept the value illegible to serve as default value for unclear/@reason. It has no effect in practice.

@danbalogh
Copy link
Collaborator

Still, I would prefer if none of our files had it explicitly. And if a default value is essential for good practice, then I think it had better be "damage". "Unclear because it is illegible" is, after all, a sort of tautology.

@arlogriffiths
Copy link
Collaborator Author

Zaki has jusr corrected his file texts/DHARMA_DiplEdCandrakiranaPerpusnasL241.xml.

@aditiagunawan : could you please correct your files by changing <unclear reason="illegible"> to <unclear>, if necessary with addition of <!-- A COMMENT --> or <note>A NOTE</note>?

@arlogriffiths
Copy link
Collaborator Author

@danbalogh : if the SIDDHAM hack is going to be made unavailable, will you make all the necessary manual adjustments in the SIDDHAM files?

@danbalogh
Copy link
Collaborator

The Siddham files have all been adjusted a long time ago without manual checking. They now have
<supplied reason="lost"><!-- CHECK if <unclear> applies better.--> to call attention to these spots in manual revision. The files where unclear reason illegible is present are only those in the backup folder, the original siddham XML files.

@danbalogh
Copy link
Collaborator

I believe this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants