Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small presentational improvements #288

Closed
arlogriffiths opened this issue Apr 19, 2024 · 6 comments
Closed

small presentational improvements #288

arlogriffiths opened this issue Apr 19, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@arlogriffiths
Copy link
Collaborator

I don't know how closely our final website is going to resemble what dharmalekha.info looks like now, but I hope the plan is to evolve incrementally from what it looks like today. If that is correct, may I suggest the following small changes?

  1. When Apparatus for an epigraphic edition is substantial, it stands in the way of jumping back and forth between edited text and translation. What about offering the option to collapse display of Apparatus?

  2. I'd like hyphens to be auto-replaced by en-dashes in display of the values of @n on <p> in div type="translation">.

  3. At the top left of our screens, it might be nice if instead of the DHARMA button we could have a button using our special logo (the one that is also our avatar at https://github.com/erc-dharma).

@arlogriffiths arlogriffiths added the enhancement New feature or request label Apr 19, 2024
@manufrancis
Copy link
Collaborator

I am fine with 1, 2, and 3.

@michaelnmmeyer
You will find the logos here
https://sharedocs.huma-num.fr/wl/?id=3xfoJH7gvpJnkJ5NQJCBwpL52elYtstJ

@michaelnmmeyer
Copy link
Member

OK, noted. For the logo, though, we will probably need a smaller one.

@arlogriffiths
Copy link
Collaborator Author

maybe for this specific context use the same reduced version as in our github avatar

image

or the whole bull if possible but without the word dharma.

@arlogriffiths
Copy link
Collaborator Author

looks great! thanks!

Capture d’écran 2024-04-26 à 18 14 24

@arlogriffiths
Copy link
Collaborator Author

I think only task 2 (hyphens to en-dash in <p n="xxx-yyy"> in translation) remains

@arlogriffiths
Copy link
Collaborator Author

thanks for carrying out all these modifications!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants