Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

values of @place on <add> #176

Open
arlogriffiths opened this issue May 19, 2022 · 6 comments
Open

values of @place on <add> #176

arlogriffiths opened this issue May 19, 2022 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed

Comments

@arlogriffiths
Copy link
Collaborator

@ajaniak and @danbalogh

Not sure if this is specific to the critical editions schema or inherited from EGD, but we don't seem to have the values "margin_right" and "margin_left", which latter I need for the case shown here.

Capture d’écran 2022-05-19 à 22 01 02

Capture d’écran 2022-05-19 à 22 03 37

@arlogriffiths arlogriffiths added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels May 19, 2022
@danbalogh
Copy link
Collaborator

In the EGD (§4.4.2) we have chosen to go with @place="left" for things located in the left margin. Likewise, "right", "top" and "bottom".

My first suggestion is that you follow the same system for critical editions.

If you are sure you want to diverge from it, then again, it would be better to follow the TEI recommendation, according to which "left" and "right" mean to the left and to the right of a vertically written line (and are thus irrelevant), "top" and "bottom" mean the same as in our system, and there is just "margin" for "left or right margin or both", without distinction. I'm also amenable to changing the EGD system to the TEI suggested one. I don't recall if we had any particular reasons for defining "left" and "right" as left and right margin.

@danbalogh
Copy link
Collaborator

I see that EGC §5.5.12.1 describes the same system as the EGD, at least as far as "left" and "right" are concerned.

@ajaniak
Copy link
Member

ajaniak commented May 31, 2022

I thing we should keep left and right to keep it simple and consistent in the project. Digital Latin Library have chosen to use the value margin without precision of left or right to resolve this issue, if eventually you feel it is more important to emphasize this information over than the specific spot.

I suppose we could figure also another system than <add> using <label> maybe to represent a sort of heading attached to a paragraph or sequence of paragraphs or to a group of verse lines not treated as a structural division. And probably adding an attribute @place="margin" or the equivalent. However, I guess it depends on what exactly is in your margin.

Margins have also been encoded as <note> in TEI projects or simply described thanks to <additions> in the header.

@arlogriffiths
Copy link
Collaborator Author

The issue never seems to have been resolved. I have just checked the file and find that I had @place="top" which must have been a stopgap because I couldn't use a factually correct value. If I implement "left" as per instructions above, VSC gives an error message (although it also declares the XML valid).

Capture d’écran 2024-05-17 à 19 07 43

@arlogriffiths arlogriffiths reopened this May 17, 2024
@danbalogh
Copy link
Collaborator

@arlogriffiths , do we want to revise the EGD to allow only "margin", consolidating all pre-existing instances of "top", "bottom", "left" and "right" to that value? This could be automated. I do prefer simplicity in encoding and find that marginal additions are extremely rare in inscriptions, but for the EGC you might prefer to keep the indication of which margin it is, and if you do, then there's no harm in doing the same in the EGD. Let me know what you prefer.

@michaelnmmeyer , if Arlo confirms that he wants to keep the permitted values of @place, then please confirm that they are now accepted as valid by the schema.

@michaelnmmeyer
Copy link
Member

@danbalogh I confirm. That said, I do not find a single use of "top".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants