Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removal of localize from ISAR #630

Open
Eddasol opened this issue Oct 21, 2024 · 1 comment · Fixed by #631
Open

Investigate removal of localize from ISAR #630

Eddasol opened this issue Oct 21, 2024 · 1 comment · Fixed by #631
Labels
improvement Improvement to existing functionality stale This issue or pull request already exists

Comments

@Eddasol
Copy link
Contributor

Eddasol commented Oct 21, 2024

Describe the improvement you would like to see
ISAR no longer sends Localize steps in full missions as this is expected to be handled by the specific robot package.

It might be possible to remove the Localize step and other localization related functionality from ISAR. Including the api endpoint for starting localization missions (might be enough to deprecate for now)

How will this change existing functionality?
This will remove unnecessary clutter and make the code more readable

How will this improvement affect the current Threat Model?
N/A

@Eddasol Eddasol added the improvement Improvement to existing functionality label Oct 21, 2024
@Eddasol Eddasol changed the title Remove localize from ISAR Investigate removal of localize from ISAR Oct 21, 2024
@Eddasol Eddasol linked a pull request Oct 21, 2024 that will close this issue
@Eddasol Eddasol reopened this Oct 24, 2024
@aeshub
Copy link
Contributor

aeshub commented Dec 23, 2024

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality stale This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants