Feat: Table footer in eds-core-react & eds-data-grid-react
#3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented the Table footer component with optional sticky property for a fixed footer. - Updated `Table.docs.mdx` to include documentation for the Table footer. - Added Table footer to the storybook to showcase various use cases. - Updated test suites to cover edge cases and ensure proper functionality of the Table footer.
feat(eds-data-grid): add Table Footer component - Added the possibility to show a footer in the data grid. - Enabled the option to make the footer fixed. - Added `footerClass` and `footerStyle` as component props for custom styling. - Updated docs and stories to include the new footer functionality. - Updated test suites to cover edge cases and ensure proper functionality of the Table Footer. chore: extract Resizer and TableCell components -`Resizer` is now a separate module to enhance reusability and scalability. - Renamed `Cell` to `TableCell` and moved it to a separate module for better reusability and scalability.
zulu-eq-bouvet
requested review from
vnys,
oddvernes and
torleifhalseth
as code owners
zulu-eq-bouvet
changed the title
eds-core-react & eds-data-grideds-core-react & eds-data-grid-react
yusijs
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
feat:add Table footer component to eds-core-reactTable.docs.mdxto include documentation for the Table footer.feat:add Table Footer component to eds-data-grid-reactfooterClassandfooterStyleas component props for custom styling.chore: extractResizerandTableCellcomponentsResizeris now a separate module to enhance reusability and scalability.CelltoTableCelland moved it to a separate module for better reusability and scalability.Why is this pull request needed?
This pull request adds support for displaying the table footer in both
eds-core-reactandeds-data-grid-react. Additionally, it introduces a property that allows the footer to be fixed akasticky.Note:We do not have a design for the Table footer component, so it currently inherits header cell token values. This can be modified in a future update.