🏷️ Make Autocomplete options prop readonly #3487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnh
force-pushed
the
chore/make-autocomplete-options-readonly
branch
from
dfb3e4f
to
a046663
Compare
oddvernes
requested changes
Jun 10, 2024
| @@ -250,7 +250,7 @@ export type AutocompleteChanges<T> = { selectedItems: T[] } | |||
|
|
|||
| export type AutocompleteProps<T> = { | |||
| /** List of options in dropdown */ | |||
| options: T[] | |||
| options: readonly T[] | |||
There was a problem hiding this comment.
looks like this needs some more work for typescript to be happy
There was a problem hiding this comment.
I will fix this (adding readonly) in another pr for #3514. By the way looks like downshift is happy again if I add as T[] behind availableItems
|
Will be resolved by #3515 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Allow
optionsprop inAutocompleteto be readonly. This way you can pass readonly arrays such as the one below without getting any TypeScript errors.Why is this pull request needed?
The autocomplete should not change the options array anyways, so I cannot see any reason why not to support readonly options prop.
(became a fork by accident)