Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete inside Menu unusable since @equinor/eds-core-react 0.38 #3580

Closed
kebonarjee opened this issue Aug 8, 2024 · 1 comment · Fixed by #3583
Closed

Autocomplete inside Menu unusable since @equinor/eds-core-react 0.38 #3580

kebonarjee opened this issue Aug 8, 2024 · 1 comment · Fixed by #3583
Labels
🐛 bug Something isn't working

Comments

@kebonarjee
Copy link

Describe the bug

When clicking on an item in an Autocomplete, given that the Autocomplete is inside a Menu, nothing happens.

Steps to reproduce the bug

  1. Place an Autocomplete within a Menu
  2. Open the Autocomplete and click on an item
  3. Nothing happens

Expected behavior

onOptionsChange() fires.

Specifications

  • Version: @equinor/eds-core-react >=0.38
  • Browser: Chrome 127.0.6533.89
  • OS: Windows 11 23H2

Additional context

See https://codesandbox.io/p/sandbox/eds-autocomplete-inside-menu-3lhlql for a minimal example.

@kebonarjee kebonarjee added the 🐛 bug Something isn't working label Aug 8, 2024
@oddvernes
Copy link
Collaborator

I found the issue and fixed it, but it should be noted that putting Autocomplete inside Menu is not something we officially support as the Autocomplete will be inaccessible by keyboard within the menu ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants