Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete: Inifinite loop triggered when pressing keyup/keydown in autocomplete with optionDisabled function #3566

Closed
mhwaage opened this issue Jul 29, 2024 · 1 comment · Fixed by #3565
Closed

Autocomplete: Inifinite loop triggered when pressing keyup/keydown in autocomplete with optionDisabled function #3566

mhwaage opened this issue Jul 29, 2024 · 1 comment · Fixed by #3565
Labels
🐛 bug Something isn't working

Comments

@mhwaage
Copy link
Contributor

mhwaage commented Jul 29, 2024

Describe the bug
For autocompletes with an optionDisabled prop that returns true for undefined, pressing keyDown or keyUp can trigger a crash.

Steps to reproduce the bug

  1. Render an autocomplete with some options disabled
  2. Filter by text so that only disabled options are visible
  3. Press up/down on keyboard
  4. Crash from infinite loop

Expected behavior

No crash

Specifications

  • Version: 0.37.0
  • Browser: Edge
  • OS: Windows

Additional context
I have added a pull request (#3565) that creates a test case that exposes this issue, and makes that test case pass.
@mhwaage mhwaage added the 🐛 bug Something isn't working label Jul 29, 2024
@mhwaage mhwaage mentioned this issue Jul 29, 2024
Merged
@mhwaage
Copy link
Contributor Author

mhwaage commented Jul 30, 2024 •
edited
Loading

As described, this is a near duplicate of #3521 which was fixed in #3534 . However, #3534 failed to fix an edge case where there are non-disabled items that have been filtered out via the search field.

@oddvernes oddvernes linked a pull request Aug 5, 2024 that will close this issue
Bugfix/add missing bounds check for findIndex #3565
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/add missing bounds check for findIndex mhwaage/design-system
1 participant
@mhwaage