Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨: Pipetest Circuit Diagram #833

Open
1 of 2 tasks
kjellhaaland opened this issue Jan 30, 2024 · 4 comments
Open
1 of 2 tasks

✨: Pipetest Circuit Diagram #833

kjellhaaland opened this issue Jan 30, 2024 · 4 comments
Labels
feature question Further information is requested

Comments

@kjellhaaland
Copy link
Contributor

kjellhaaland commented Jan 30, 2024

Expected outcome

Add support for pipetest to the Circuit Diagram. Currently the diagram only supports HT.
Similar view as the JC Circuit Diagram.

image

The relation betweeen HT cables and Pipetest need to be added, as it is currently not part of the data returned from the API.

Business Value / Developer Experience

Enables the user to se pipetests related to HeatTrace.

Acceptance Criteria

  • All Pipetests related to all HT cables are shown in the Circuit Diagram.
  • The currently selected Pipetest is highlighted in the diagram
@kjellhaaland
Copy link
Contributor Author

The current API implementation (ElectricalConsumers), does not return pipetests as part of the "network tree".
It uses the /portal/{facility}/ele-net-consumer?tagNo={tagNo} endpoint in STID to fetch the data.

How to get the Pipetest tags as part of the data returned from STID?

Some suggestions to solutions

  1. Change the underlying view in the STID API, to include the pipetest tags in the response
  2. Use the already implemented EnrichWithFamTagsAsync in the ElectricalConsumers API to enrich the data. This function gets tags from Custom_ElectricalConsumersMCCR. Can Pipetests in some way be included here?
  3. Enrich the data from STID with data from FAM by using the Custom_PipetestV1 view, by querying for HT tags.

@atlewee any thoughts on this?

@kjellhaaland kjellhaaland self-assigned this Jan 30, 2024
@atlewee
Copy link

atlewee commented Jan 30, 2024

@kjellhaaland
Should be somehow picked up from this table in FAM:
( master mapping table between HT and PipeTest )
TagId is htCable id
image

@kjellhaaland kjellhaaland added blocked question Further information is requested and removed blocked labels Feb 2, 2024
@kjellhaaland
Copy link
Contributor Author

The Circuit Diagram is partially implemented in the Pipetest app.

  • Data is still fetched from STID and not FAM. (Same as HT)
  • HT Cables relation between Pipetest and HT is missing in JCA.
  • The currently selected pipetest is not highlighted in the CircuitDiagram, as it is missing the relation with HT. (in the data from STID)

@ken-mellem and @atlewee, is the current implementation sufficient, or should we start implementing the solution mentioned by Atle?

@kjellhaaland Should be somehow picked up from this table in FAM: ( master mapping table between HT and PipeTest ) TagId is htCable id image

@ken-mellem
Copy link
Contributor

@kjellhaaland I guess this warrants a chat.

@ken-mellem ken-mellem added this to the 👑 Pipetest app milestone Feb 9, 2024
@kjellhaaland kjellhaaland removed their assignment May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants