SWCR: SWCR.Status Field from SWCR

[BenSvend]

Summary

It was discovered by users of the SWCR sidesheet in Handover that the SWCR.Status field displayed incorrect data.

• Handover Transition - SWCR status code incorrect. e.g.,, Comm. pkg. 8730-H03 lighthouse-client#1494

Feedback from FAM and Procosys verified that there is a mistake on their end:

"Status is a calculated field, based on several tables, it is not persisted. We do send the current status when sending the swcr, but perhaps that is a mistake.
This is a bug, and I'm not sure how to solve it, will have to work it out."

Decision

Create a new Custom_View in FAM for this specific calculation.

UAT

• correct SWCR Status is available in FAM
• SWCR Status is viewed in sidesheet for Handover.

[Gustav-Eikaas]

After a chat with Atle and Tord we looked into the possibility of calculating this status in FAM. This calculation requires PCS library but we think we have all the required fields already in FAM

[BenSvend]

FYI. @atlewee @ken-mellem @Gustav-Eikaas

FAM is currently holding internal discussions on whether or not they should do the calculations themselves, or have us do it. I've therefore decided to wait for their conclusion before trying to do the calculations myself. Stian Håland at FAM indicated that they would have a conclusion withing next week.

[ken-mellem]

FAM has concluded: they have labeled this field as a custom field and will not implement in FAM.

[2:50 PM] Stian Håland (Bouvet ASA)
Completion.CompletionSoftwareChangeRecord.Status
Hi,

As previously mentioned, there are currently some issues with how Completion.CompletionSoftwareChangeRecord.Status is being calculated/sent to FAM, as updates to this status does not trigger a resend from PCS -> FAM.

As Atle Wee Førre points out, it should be possible to calculate this based on data currently available in FAM. Since this is a calculated column, we would like to handle this as a "Custom" value, which means that the calculation should be done on the consumer side / by the consumers of FAM.

Ken Vegard Mellem (Bouvet ASA) is this okay with you/your team? In short, your team will have to do this calculation.

I agree with this conclusion.

Options

We must discuss how to resolve this. Three options

1. calculate in our backend
2. create a new custom view
3. remove the status field

I guess option 3 is not really an option as the field is being used. If we go for option 2, then this calculation is a good first candidate to move to the new self-service - both as an example of a POC but also to showcase its use-case and value.

I do not know the complexity of the PCS calculation we would be replicating. But we must make sure to quality assure that we are able to calculate the same results. This is hardly ideal... PCS should be offered the option of commenting on this.

[ken-mellem]

Decision: for now, we create a new custom view - which will be moved to our self-service when that is ready. For now, it will reside in FAM.

[ken-mellem]

Current status

@BenSvend

• Vi mangler noe data i FAM, Atle har etterspurt dette nå. Koden er også ganske omfattende, og det må nok gjøres en god del testing.
• Når jeg går gjennom å dobbeltsjekker feilene som han har påpekt så har kalkulasjonene jeg nå har gjort klart å få riktig status på alle de han påpekte var feil. Så kan virke som jeg kun mangler det feltet fra FAM nå for å være ferdig.

[ken-mellem]

Status update

We had a meeting with Atle and Tord, Gustav and Ben today. The status field is not the entire story. A given status for an SWCR is configurable for each facility in PCS; a status called "closed" may actually cover both "rejected" and "closed" in the classification of each SWCR, which turns out is the field we really want to show. There is currently no field in FAM which can store this mapping.

Short term solution: we will revert to fetching SWCR sidesheet using fusion-data-proxy until we have resolved the issue.

[Gustav-Eikaas]

PR merged. QA verified. Rolled out into production. Verified.

Old service message removed, new info one added saying the status is now correct

[ken-mellem]

Reduced urgency as we now have a temporary fix. Thanks @Gustav-Eikaas !

[ken-mellem]

• https://github.com/equinor/lighthouse/discussions/464

[ken-mellem]

ProCoSys now has this on their list

• https://statoildeveloper.visualstudio.com/Statoil.NextGenProCoSys/_workitems/edit/109025

[JanskiB]

FYI @ken-mellem
112033 [Send SWCR to FAM when SWCR Signature changes] status change to Done in ProCoSys