Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛: Workorder MCCR tab: Checklists is missing #621

Open
atlewee opened this issue Oct 6, 2023 · 9 comments
Open

🐛: Workorder MCCR tab: Checklists is missing #621

atlewee opened this issue Oct 6, 2023 · 9 comments
Assignees
Labels
bug Something isn't working on-hold

Comments

@atlewee
Copy link

atlewee commented Oct 6, 2023

Description

Some workorders is missing MCCRs in projectportal.
Could it be because the checklists are connected to dummy-tags?

Reproduce

Open Workorder app on OGP project
Open workorder: 25588400
image

Expected behavior

Number of checklists should match ProCoSys

@atlewee atlewee added the bug Something isn't working label Oct 6, 2023
@aman-riaz
Copy link
Contributor

The logic in CustomAPI_WorkOrderChecklists (the api used to show MCCRs) filters out all tags which are not lci tags. What Atle is saying seems to be the case.
I suggest switching to using another view: Custom_WorkOrderChecklist (This one should have all of them) or ask FAM to change the logic in CustomAPI_WorkOrderChecklists.

CustomAPI views are owned and maintained by FAM. @Gustav-Eikaas

@MagnusGjosund
Copy link
Contributor

@aman-riaz can you add projectSchema to Custom_WorkOrderChecklist view?

@kjellhaaland
Copy link
Contributor

I have discussed this with Magnus, and need some more context from @Gustav-Eikaas on what was discussed with regards to adding projectSchema to the view.

Notes:
The Custom_WorkOrderChecklist view is missing some key fields, that is currently included in CustomAPI_WorkOrderChecklists.
This includes tagId, description, mccrType, mccrStatus, mcPkgId, commpkgId and mccrResponsible

See https://famapi.equinor.com/index.html for comparing the models.

One solution would be to add the missing fields to the Custom_WorkOrderChecklist

@Gustav-Eikaas
Copy link
Contributor

@aman-riaz Is it possible for you to add the missing fields so we can switch to the other view and close this view?

@aman-riaz
Copy link
Contributor

aman-riaz commented Jan 25, 2024

Custom_WorkOrderChecklist_v1 now ready in FAM-api with new fields.

I suggest when you fetch the data, set a filter if possible to "Custom_WorkOrderChecklist_v1 .FormularGroup = "MCCR". This way you can only fetch the subset of data necessary for this purpose.

mccrType = FormularType
mccrStatus = ChecklistStatus
mcPkgId = MechanicalCompletionPacakgeId
commpkgId = CommissioningPackageId
mccrResponsible = ChecklistResponsible
Description = WorkOrderDescription
TagId = TagId (for display use TagNo)

@kjellhaaland

@kjellhaaland
Copy link
Contributor

kjellhaaland commented Feb 9, 2024

@aman-riaz the new view is missing MechanicalCompletionPackageUrlId and CommissioningPackageUrlId in order to create links to ProCoSys.

Can these fields be added to the view Custom_WorkOrderChecklist_v1?

@kjellhaaland
Copy link
Contributor

This issue is on hold until https://github.com/equinor/fusion-data-gateway/issues/545 is ready

@ken-mellem
Copy link
Contributor

@kjellhaaland

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on-hold
Projects
None yet
Development

No branches or pull requests

6 participants