Skip to content

Commit fbb4bf2

Browse files
tanruixiangepwalsh
authored andcommitted
[Misc] Fix the benchmark's README and improve the error messages for the benchmark's argument checks (vllm-project#22654)
Signed-off-by: tanruixiang <tanruixiang0104@gmail.com>
1 parent ad58304 commit fbb4bf2

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

benchmarks/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@ vllm serve Qwen/Qwen2-VL-7B-Instruct
194194
```bash
195195
vllm bench serve \
196196
--backend openai-chat \
197+
--endpoint-type openai-chat \
197198
--model Qwen/Qwen2-VL-7B-Instruct \
198199
--endpoint /v1/chat/completions \
199200
--dataset-name hf \
@@ -230,6 +231,7 @@ vllm serve Qwen/Qwen2-VL-7B-Instruct
230231
```bash
231232
vllm bench serve \
232233
--backend openai-chat \
234+
--endpoint-type openai-chat \
233235
--model Qwen/Qwen2-VL-7B-Instruct \
234236
--endpoint /v1/chat/completions \
235237
--dataset-name hf \
@@ -244,6 +246,7 @@ vllm bench serve \
244246
```bash
245247
vllm bench serve \
246248
--backend openai-chat \
249+
--endpoint-type openai-chat \
247250
--model Qwen/Qwen2-VL-7B-Instruct \
248251
--endpoint /v1/chat/completions \
249252
--dataset-name hf \

vllm/benchmarks/datasets.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -740,10 +740,11 @@ def get_samples(args, tokenizer) -> list[SampleRequest]:
740740
"openai-chat",
741741
"openai-audio",
742742
]:
743-
# multi-modal benchmark is only available on OpenAI Chat backend.
743+
# multi-modal benchmark is only available on OpenAI Chat
744+
# endpoint-type.
744745
raise ValueError(
745746
"Multi-modal content is only supported on 'openai-chat' and "
746-
"'openai-audio' backend.")
747+
"'openai-audio' endpoint-type.")
747748
input_requests = dataset_class(
748749
dataset_path=args.dataset_path,
749750
dataset_subset=args.hf_subset,

0 commit comments

Comments
 (0)