Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to d3 seems to have broken epoch #226

Open
BenMcLean opened this issue Jul 6, 2016 · 4 comments
Open

Update to d3 seems to have broken epoch #226

BenMcLean opened this issue Jul 6, 2016 · 4 comments

Comments

@BenMcLean
Copy link

BenMcLean commented Jul 6, 2016

See changelog here: https://github.com/d3/d3/releases

v3.5.17 seems to be the last one that works.

@darylldawn
Copy link

Seconding this. After updating d3 to v4, epoch doesn't work since it uses d3.time.format, etc.

Thanks in advance!

@skipzero
Copy link

I take it that Epoch requires D3js < v4, from the above. Is the upgrade to v4 compatibility on the roadmap? Would be a handy thing to add to the docs, me thinks. Being new to Epoch, didn't think about at first and spent a little time wondering why it wasn't working.

@beauremus
Copy link

The documentation lays out how to fix the time issue.
https://github.com/d3/d3/blob/master/CHANGES.md#timers-d3-timer
I've done this locally and it works. There are other issues so as @zerosquadron asked, is there a roadmap for a d3 v4 rework?

@rsandor
Copy link
Collaborator

rsandor commented Oct 4, 2016

@beauremus - If you have fixed it locally, why not open a PR? I haven't had much time to work on Epoch as of late but I totally have time to review a PR or two 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants