Queue connect timer on autoconnect enable#217
Open
FreddieAkeroyd wants to merge 1 commit intoepics-modules:masterfrom
Open
Queue connect timer on autoconnect enable#217FreddieAkeroyd wants to merge 1 commit intoepics-modules:masterfrom
FreddieAkeroyd wants to merge 1 commit intoepics-modules:masterfrom
Conversation
|
❌ Build asyn 1.0.291 failed (commit f874070c2c by @FreddieAkeroyd) |
Contributor
|
I encountered this problem as well, and came to the same solution. Your patch looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @MarkRivers we have an issue with late enabling of autoconnect and I was wondering if this was a valid fix.
We setup some ports with
drvAsynIPPortConfigureand autoconnect disabled and then later in SNL we usepasynManager->autoConnect(like inside theasynAutoConnectepics cmd) to enable autoconnect . It seems with this approach that we get an initial connection attempt, but if this fails no further attempts are queued.Is the correct fix to start a connection timer in the
autoConnectAsynfunction or is another approach better?Thanks,
Freddie