Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: va-rating #3270

Open
2 of 4 tasks
Tracked by #3223
kushich opened this issue Mar 29, 2023 · 2 comments
Open
2 of 4 tasks
Tracked by #3223

a11y: va-rating #3270

kushich opened this issue Mar 29, 2023 · 2 comments
Labels
accessibility Relates to accessibility implementation Requires implementation

Comments

@kushich
Copy link
Member

kushich commented Mar 29, 2023

  • step 1: investigate a11y guides for this component;
  • step 2: discuss with team;
  • step 3: implement required functionality;
  • step 4: add docs page section about a11y.


@kushich kushich self-assigned this Mar 29, 2023
@kushich
Copy link
Member Author

kushich commented Mar 30, 2023

Keyboard navigation (ref)

When I use I see/hear
Tab Focus visibly moves to the checked radio button in the group. If a radio button is not checked, focus moves to the first radio button in the group.
Spacebar If the radio button with focus is not checked, changes the state to checked. Otherwise, does nothing.
Arrows Moves focus to and checks the previous or next radio button in the group (if we focused on the last/first element, the next focus move should be on the first/last element (loop))

Semantics

VaRatingItem should be a radio input element as this is a choice between ratings.

@kushich kushich removed their assignment Mar 30, 2023
@kushich kushich added team discussion Feedback wanted accessibility Relates to accessibility labels Mar 30, 2023
@asvae
Copy link
Member

asvae commented Mar 30, 2023

For spacebar we have uncheck behavior for clearable.

@asvae asvae added implementation Requires implementation and removed team discussion Feedback wanted labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Relates to accessibility implementation Requires implementation
Projects
None yet
Development

No branches or pull requests

2 participants