Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: va-badge #3254

Closed
2 of 4 tasks
Tracked by #3223
kushich opened this issue Mar 27, 2023 · 2 comments · Fixed by #3450
Closed
2 of 4 tasks
Tracked by #3223

a11y: va-badge #3254

kushich opened this issue Mar 27, 2023 · 2 comments · Fixed by #3450
Assignees
Labels
accessibility Relates to accessibility implementation Requires implementation

Comments

@kushich
Copy link
Member

kushich commented Mar 27, 2023

  • step 1: investigate a11y guides for this component;
  • step 2: discuss with team;
  • step 3: implement required functionality;
  • step 4: add docs page section about a11y.
@kushich kushich self-assigned this Mar 27, 2023
@kushich
Copy link
Member Author

kushich commented Mar 27, 2023

Right now we are using role="alert" for our badge component. Looks like this is not correct (1):
Screenshot 2023-03-27 at 15 15 57
I think we should use role="status" instead (2):
Screenshot 2023-03-27 at 15 25 00

According to role="status" docs page (3) we should use aria-labelledby if text is visible. In our case I think we should pass value of text prop into this attribute.

Here is an implementation example on w3 (4).

@kushich kushich added team discussion Feedback wanted accessibility Relates to accessibility labels Mar 27, 2023
@kushich kushich removed their assignment Mar 27, 2023
@rustem-nasyrov
Copy link
Collaborator

Right now I'm working on va-badge component, I can handle this issue, after discussion.

@asvae asvae added implementation Requires implementation and removed team discussion Feedback wanted labels Mar 30, 2023
@rustem-nasyrov rustem-nasyrov mentioned this issue May 29, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Relates to accessibility implementation Requires implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants